Skip to content

Fix FRR image override reverted by CNO reconciliation#76529

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
pperiyasamy:fix_cno_unmanaged_race
Mar 21, 2026
Merged

Fix FRR image override reverted by CNO reconciliation#76529
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
pperiyasamy:fix_cno_unmanaged_race

Conversation

@pperiyasamy
Copy link
Member

The CNO was still reconciling and reverting image changes after being set to Unmanaged. Restart the network-operator deployment and wait for it to complete before updating frr-k8s image.

@openshift-ci openshift-ci bot requested review from ricky-rav and zshi-redhat March 19, 2026 10:13
@pperiyasamy
Copy link
Member Author

/test step-registry-shellcheck

@pperiyasamy pperiyasamy force-pushed the fix_cno_unmanaged_race branch from be1a315 to 7a2f0f4 Compare March 19, 2026 10:32
@pperiyasamy
Copy link
Member Author

/assign @kyrtapz @jcaamano

@jcaamano
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Mar 19, 2026
@pperiyasamy
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pperiyasamy
Copy link
Member Author

@lmiccini can you check shellcheck failure #76529 (comment) ? It seems cb37380 is not fixing it.

@pperiyasamy
Copy link
Member Author

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pperiyasamy
Copy link
Member Author

/pj-rehearse ci/rehearse/openshift/ovn-kubernetes/release-4.22/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview
/pj-rehearse ci/rehearse/openshift/ovn-kubernetes/release-4.22/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: job(s): ci/rehearse/openshift/ovn-kubernetes/release-4.22/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@pperiyasamy
Copy link
Member Author

/pj-rehearse ci/rehearse/openshift/ovn-kubernetes/release-4.22/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: job(s): ci/rehearse/openshift/ovn-kubernetes/release-4.22/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview either don't exist or were not found to be affected, and cannot be rehearsed

@pperiyasamy
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.22-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pperiyasamy
Copy link
Member Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.22-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

The CNO was still reconciling and reverting image changes after being
set to Unmanaged. Restart the network-operator deployment and wait for
it to complete before updating frr-k8s image.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@pperiyasamy pperiyasamy force-pushed the fix_cno_unmanaged_race branch from 7a2f0f4 to 91d4338 Compare March 20, 2026 13:42
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@pperiyasamy: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-bgp openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-5.0-e2e-metal-ipi-ovn-dualstack-bgp openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.23-e2e-metal-ipi-ovn-dualstack-bgp openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.22-e2e-metal-ipi-ovn-dualstack-bgp openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-metal-ipi-ovn-dualstack-bgp openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-metal-ipi-ovn-dualstack-bgp openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-metal-ipi-ovn-dualstack-bgp openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-5.0-e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.23-e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.22-e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-5.0-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-5.0-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.23-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.23-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.22-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.22-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/origin presubmit Registry content changed

A total of 115 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcaamano
Copy link
Contributor

/lgtm
/approve
/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next

@openshift-ci-robot
Copy link
Contributor

@jcaamano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pperiyasamy
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 21, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2026

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-network-operator/release-4.22/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview 7a2f0f4 link unknown /pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.22-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview
ci/rehearse/openshift/ovn-kubernetes/release-4.22/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next 7a2f0f4 link unknown /pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.22-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next
ci/rehearse/openshift/ovn-kubernetes/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next 91d4338 link unknown /pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2ec5759 into openshift:main Mar 21, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants